bench: refactor random value generation #5465

saurabhraghuvanshii · 2025-02-26T18:58:32Z

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

refractor random number generation in math/base/special/binet*

Related Issues

Does this pull request have any related issues?

This pull request:

resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-02-26T19:02:31Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/binet	$\color{green}250/250$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}250/250$ $\color{green}+100.00\%$
math/base/special/binomcoef	$\color{green}269/269$ $\color{green}+100.00\%$	$\color{green}34/34$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}269/269$ $\color{green}+100.00\%$
math/base/special/boxcox	$\color{green}208/208$ $\color{green}+100.00\%$	$\color{green}13/13$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}208/208$ $\color{green}+100.00\%$
math/base/special/boxcox1p	$\color{green}232/232$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}232/232$ $\color{green}+100.00\%$
math/base/special/boxcox1pinv	$\color{green}224/224$ $\color{green}+100.00\%$	$\color{green}12/12$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}224/224$ $\color{green}+100.00\%$
math/base/special/boxcoxinv	$\color{green}218/218$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}218/218$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

anandkaranubc

This PR still requires a lot of changes in order to be merged.

lib/node_modules/@stdlib/math/base/special/binet/benchmark/benchmark.js

lib/node_modules/@stdlib/math/base/special/binet/benchmark/benchmark.native.js

lib/node_modules/@stdlib/math/base/special/binet/benchmark/c/benchmark.c

lib/node_modules/@stdlib/math/base/special/binet/benchmark/c/native/benchmark.c

lib/node_modules/@stdlib/math/base/special/boxcox1p/benchmark/benchmark.js

lib/node_modules/@stdlib/math/base/special/boxcox1p/benchmark/benchmark.native.js

lib/node_modules/@stdlib/math/base/special/boxcoxinv/benchmark/benchmark.js

lib/node_modules/@stdlib/math/base/special/boxcoxinv/benchmark/benchmark.native.js

lib/node_modules/@stdlib/math/base/special/boxcox1pinv/benchmark/c/native/benchmark.c

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: failed ---

lib/node_modules/@stdlib/math/base/special/boxcoxinv/benchmark/benchmark.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/math/base/special/boxcox/benchmark/benchmark.js

lib/node_modules/@stdlib/math/base/special/boxcox/benchmark/benchmark.native.js

saurabhraghuvanshii · 2025-03-04T16:45:30Z

/stdlib help

stdlib-bot · 2025-03-04T16:45:51Z

@saurabhraghuvanshii, available slash commands include:

/stdlib check-files - Check for required files.
/stdlib update-copyright-years - Update copyright header years.
/stdlib lint-autofix - Auto-fix lint errors.
/stdlib merge - Merge changes from develop branch into this PR.
/stdlib rebase - Rebase this PR on top of develop branch.

saurabhraghuvanshii · 2025-03-04T16:46:27Z

/stdlib merge

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc

The PR looks ready to be merged. Thanks for making those changes!

saurabhraghuvanshii · 2025-03-04T20:43:43Z

I have to thanks you for reviewing my commits . I try to improve more .

Planeshifter

Let's get this one in. 🎉

Thanks @saurabhraghuvanshii for your work on this and @anandkaranubc for leaving review comments; much appreciated!

stdlib-bot · 2025-03-05T02:46:39Z

PR Commit Message

bench: refactor random value generation

PR-URL: https://github.com/stdlib-js/stdlib/pull/5465

Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Karan Anand <anandkaranubc@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 26, 2025

kgryte requested a review from anandkaranubc February 27, 2025 09:58

anandkaranubc requested changes Mar 1, 2025

View reviewed changes

anandkaranubc added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 1, 2025

saurabhraghuvanshii added 2 commits March 1, 2025 22:12

Merge branch 'stdlib-js:develop' into random-math1

2f4b4ae

saurabhraghuvanshii requested a review from anandkaranubc March 2, 2025 15:19

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 2, 2025

anandkaranubc reviewed Mar 2, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/boxcoxinv/benchmark/benchmark.js Outdated Show resolved Hide resolved

saurabhraghuvanshii added 2 commits March 3, 2025 00:22

Merge branch 'stdlib-js:develop' into random-math1

cfce2c1

anandkaranubc requested changes Mar 4, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/boxcox/benchmark/benchmark.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/math/base/special/boxcox/benchmark/benchmark.native.js Outdated Show resolved Hide resolved

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 4, 2025

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 4, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 4, 2025

Merge remote-tracking branch 'upstream/develop' into random-math1

e59929c

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 4, 2025

anandkaranubc approved these changes Mar 4, 2025

View reviewed changes

anandkaranubc removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Mar 4, 2025

anandkaranubc requested a review from stdlib-bot March 4, 2025 20:37

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 4, 2025

Planeshifter approved these changes Mar 5, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 5, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 5, 2025

Planeshifter merged commit 9b2d78d into stdlib-js:develop Mar 5, 2025
47 checks passed

saurabhraghuvanshii deleted the random-math1 branch March 5, 2025 17:23

Uh oh!

bench: refactor random value generation #5465

bench: refactor random value generation #5465

Uh oh!

Conversation

saurabhraghuvanshii commented Feb 26, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saurabhraghuvanshii commented Mar 4, 2025

Uh oh!

stdlib-bot commented Mar 4, 2025

Uh oh!

saurabhraghuvanshii commented Mar 4, 2025

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

saurabhraghuvanshii commented Mar 4, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Mar 5, 2025 • edited by Planeshifter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Commit Message

Uh oh!

Uh oh!

Uh oh!

stdlib-bot commented Feb 26, 2025 •

edited

Loading

stdlib-bot commented Mar 5, 2025 •

edited by Planeshifter

Loading